Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove unneeded capabilities fetching on every window open #1073

Merged
merged 2 commits into from
Jan 30, 2025
Merged

fix: remove unneeded capabilities fetching on every window open #1073

merged 2 commits into from
Jan 30, 2025

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Jan 30, 2025 •
edited
Loading

☑️ Resolves

  1. Pinia executes setNextcloudTalkHash even when there is the same hash already (check is inside)
  2. Talk Desktop is sure, setNextcloudTalkHash is only dispatched when there is a NEW hash, so it marks the hash as dirty...
  3. Each second load is marked as dirty and fetches capabilities...

Either I missed a difference between new Pinia and old Vuex hash store implementation. Or I'm silly and there always was an issue 🤦

  • Fixed the issue
  • Renamed talkHashSetInitial to talkHashUpdate to not confuse

@ShGKme ShGKme added this to the 🪴 Next Release milestone Jan 30, 2025
@ShGKme ShGKme self-assigned this Jan 30, 2025
Antreesy
Antreesy approved these changes Jan 30, 2025
View reviewed changes
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested

@ShGKme ShGKme merged commit 8417f4f into main Jan 30, 2025
10 checks passed
@ShGKme ShGKme deleted the fix/unneeded-capabilities-fetch-on-window-open branch January 30, 2025 19:53
@ShGKme ShGKme mentioned this pull request Feb 4, 2025
Merged
@ShGKme ShGKme modified the milestones: v1.1.3-beta, v1.1.2-beta Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Antreesy Antreesy Antreesy approved these changes

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

@DorraJaouad DorraJaouad Awaiting requested review from DorraJaouad

Assignees

@ShGKme ShGKme

Labels
3. to review bug Something isn't working performance 🚀 regression
Projects
None yet
Milestone
v1.1.2-beta
Development

Successfully merging this pull request may close these issues.
2 participants
@ShGKme @Antreesy