build: unify distribution file names #906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Grigorii K. Shartsev <[email protected]>
ShGKme
force-pushed
the
build/align-package-names
branch
from
86b1d4a to
8c8b5c1
Compare
nickvergessen
approved these changes
Nov 19, 2024
| @@ -18,7 +18,7 @@ require('dotenv').config() | |||
| const CONFIG = { | |||
| // General | |||
| applicationName: packageJSON.productName, | |||
| applicationNameSanitized: packageJSON.productName.replaceAll(' ', '-'), | |||
| applicationNameSanitized: packageJSON.productName.replaceAll(' ', '.'), | |||
There was a problem hiding this comment.
dash is a problem? Would prefer that
There was a problem hiding this comment.
No. But I didn't like that space replacer and name parts separator are the same symbol 🐧
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
Currently, distribution (installer) file names are different from different packaging tools.
This PR unifies it in a format:
Where platform is renamed to a user-friendly name:
darwin=>macoswin32=>windowsWhile it is cool to have a version in the file name, it makes it hard to have a constant link to the installer. The version is removed.
Examples:
Nextcloud.Talk-macos-universal.dmgNextcloud.Talk-windows-x64.exeNextcloud.Talk-windows-x64.msiNextcloud.Talk-linux-x64.flatpakNextcloud.Talk-linux-x64.zipImplementation notes
All packagers have different output paths, incl. folder structure, and filenames.
In most of them, there is no option to specify or override it 😒
Hotfix: manually move files to the correct location.
Alternatives
@electron/forgemakers, add features and upstream