Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: apply selected theme also to native parts of the app #916

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Nov 21, 2024

☑️ Resolves

A minor change in theming. Simplifying pages setup and respects selected theme in all parts of the app.

  • Before we used Nextcloud theme via [data-theme-*]. It has 2 drawbacks:
    • Requires setting attrs initially on every window
    • Native parts of the app have a system theme
  • Now using a native theme:
    • Requires settings only once on app init
    • Works on all the parts

🖼️ Screenshots

Example - a Light theme on a Dark system

🏚️ Before 🏡 After
image image

@ShGKme ShGKme added bug Something isn't working 3. to review labels Nov 21, 2024
@ShGKme ShGKme self-assigned this Nov 21, 2024
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested

@ShGKme ShGKme merged commit 21dbaf2 into main Nov 22, 2024
10 checks passed
@ShGKme ShGKme deleted the fix/native-theme branch November 22, 2024 12:04
@ShGKme ShGKme mentioned this pull request Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants