Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ability to view context of messages in media viewer #1916

Merged
merged 2 commits into from
Dec 15, 2024

Conversation

rapterjet2004
Copy link
Contributor

- presents with ContextChatViewController with limit of 10
- NCMediaViewerViewController now needs an instance of room when initialized

Signed-off-by: rapterjet2004 <[email protected]>
Copy link
Collaborator

@SystemKeeper SystemKeeper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very quick review comments ;)

NextcloudTalk/NCMediaViewerViewController.swift Outdated Show resolved Hide resolved
NextcloudTalk/NCMediaViewerViewController.swift Outdated Show resolved Hide resolved
NextcloudTalk/NCMediaViewerViewController.swift Outdated Show resolved Hide resolved
NextcloudTalk/NCMediaViewerViewController.swift Outdated Show resolved Hide resolved
- Embedded chatViewController in NCNavigationController
- Changed spacing between toolBarItems to be 20
- Changed getMessageContext to have a limit of 50 messages
- Enabled showMessageButton in mediaViewerPageMediaDidLoad

Signed-off-by: rapterjet2004 <[email protected]>
Copy link
Collaborator

@SystemKeeper SystemKeeper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you!
I noticed a few small things when testing this (not only related to this PR), we can fix in a follow-up.

@SystemKeeper SystemKeeper merged commit 20c6b71 into master Dec 15, 2024
11 checks passed
@SystemKeeper SystemKeeper deleted the issue-1704-open-msg-context-mediaview branch December 15, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add the ability to open message context in media view
2 participants