fix(badge): Update realm before updating the badge #1923
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to reproduce:
After we removed the notifications, we also update the badgenumber:
talk-ios/NextcloudTalk/NCNotificationController.m
Lines 308 to 319 in a06a909
Since this is wrapped in a dispatch, it is possible that realm was not yet fully updated on the other thread:
talk-ios/NextcloudTalk/NCNotificationController.m
Lines 229 to 231 in a06a909
Resulting in a wrong badge count.