Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repeating tasks #2317

Closed
wants to merge 3 commits into from
Closed

Repeating tasks #2317

wants to merge 3 commits into from

Conversation

sunkup
Copy link

@sunkup sunkup commented Aug 15, 2023

No description provided.

@raimund-schluessler
Copy link
Member

@jancborchardt Could you please invite @sunkup to nextcloud/tasks, so he can push his branch here?

@codecov
Copy link

codecov bot commented Aug 15, 2023

Codecov Report

Merging #2317 (83bf12e) into master (f9d4900) will decrease coverage by 0.08%.
The diff coverage is 17.39%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2317      +/-   ##
==========================================
- Coverage   27.33%   27.25%   -0.08%     
==========================================
  Files          60       60              
  Lines        2923     2946      +23     
  Branches      744      748       +4     
==========================================
+ Hits          799      803       +4     
- Misses       2124     2143      +19     

@jancborchardt
Copy link
Member

@sunkup invited you to the Nextcloud org and the Tasks team here on Github. I can also give you a guest account on our Nextcloud instance where we have various community channels. Let me know and I can add you with the email address used in your commits. :)

Also, are you coming to the Nextcloud Conference this September again? https://nextcloud.com/conference-2023/

@sunkup
Copy link
Author

sunkup commented Aug 15, 2023

Great, thanks. Yes, you can add me to your nc instance please ~

And yes! All of us at bitfire plan to go :)

@raimund-schluessler
Copy link
Member

@sunkup Could you push your changes to the nextcloud/tasks repo, please? Then it's easier to collaborate.

@sunkup
Copy link
Author

sunkup commented Aug 17, 2023

@sunkup Could you push your changes to the nextcloud/tasks repo, please? Then it's easier to collaborate.

It's all here already. There is not more than 9b27260 and 0acd5ae.

I did not save/commit my experimental work - where I reused the calendar code for the sidebar UI - as it became too messy and I wanted to start over using rrule.js.

@raimund-schluessler
Copy link
Member

@sunkup Could you push your changes to the nextcloud/tasks repo, please? Then it's easier to collaborate.

It's all here already. There is not more than 9b27260 and 0acd5ae.

I did not save/commit my experimental work - where I reused the calendar code for the sidebar UI - as it became to messy and I wanted to start over using rrule.js.

Yes, I know, that's fine. I just meant that you create a branch in the tasks repository, and not in your private repo. This make checking out the PR and collaborating easier.

@sunkup
Copy link
Author

sunkup commented Aug 17, 2023

Yes, I know, that's fine. I just meant that you create a branch in the tasks repository, and not in your private repo. This make checking out the PR and collaborating easier.

ooh, ok! I just created it. You may create a new PR from it as well.

I won't work on it again before the end of the week though ~

@sunkup sunkup linked an issue Aug 17, 2023 that may be closed by this pull request
@raimund-schluessler
Copy link
Member

New PR in #2318.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Repeating tasks
4 participants