Fix calling setLastContact on boolean (#526)

Fix calling setLastContact on boolean
nextcloud · Jan 9, 2020 · bf1068c · bf1068c
2 parents 2546050 + 43c0277
commit bf1068c
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/lib/Service/SessionService.php b/lib/Service/SessionService.php
@@ -111,6 +111,9 @@ public function removeInactiveSessions($documentId = -1) {
 		return $this->sessionMapper->deleteInactive($documentId);
 	}
 
+	/**
+	 * @return bool|Session
+	 */
 	public function getSession($documentId, $sessionId, $token) {
 		if ($this->session !== null) {
 			return $this->session;
@@ -123,10 +126,9 @@ public function getSession($documentId, $sessionId, $token) {
 		}
 	}
 
-	public function isValidSession($documentId, $sessionId, $token) {
-		try {
-			$session = $this->getSession($documentId, $sessionId, $token);
-		} catch (DoesNotExistException $e) {
+	public function isValidSession($documentId, $sessionId, $token): bool {
+		$session = $this->getSession($documentId, $sessionId, $token);
+		if ($session === false) {
 			return false;
 		}
 		// TODO: move to cache