Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Focus order issues with viewer modal #2387

Closed
juliusknorr opened this issue May 12, 2022 · 3 comments
Closed

Focus order issues with viewer modal #2387

juliusknorr opened this issue May 12, 2022 · 3 comments
Assignees
@vinicius73
Labels
1. to develop accessibility bug Something isn't working

Comments

@juliusknorr
Copy link
Member

When opening a text file in viewer, focus remains in the background and the user needs to tab through all the contents in the background without seeing what they’re doing to get to the modal.
@juliusknorr juliusknorr moved this to 📄 To do (5-20 entries) in 📝 Office team Jun 10, 2022
@vinicius73 vinicius73 self-assigned this Jul 11, 2022
vinicius73 pushed a commit that referenced this issue Jul 12, 2022
⚡️ (#2387): remove events from $editor before destroy it
4dfde9f 
Signed-off-by: Vinicius Reis <[email protected]>
vinicius73 pushed a commit that referenced this issue Jul 12, 2022
♿️ (#2387): add missing aria labels
2293ad0 
Signed-off-by: Vinicius Reis <[email protected]>
vinicius73 pushed a commit that referenced this issue Jul 12, 2022
♿️ (#2387): prevent focus to go back to file list
32448ba 
Signed-off-by: Vinicius Reis <[email protected]>
vinicius73 pushed a commit that referenced this issue Jul 12, 2022
♿️ (#2387): prevent focus to go back to file list
113b9d3 
Signed-off-by: Vinicius Reis <[email protected]>
This was referenced Jul 12, 2022
Closed
Closed
vinicius73 pushed a commit that referenced this issue Jul 12, 2022
⚡️ (#2387): remove events from $editor before destroy it
42d7b2c 
Signed-off-by: Vinicius Reis <[email protected]>
vinicius73 pushed a commit that referenced this issue Jul 13, 2022
♿️ (#2387): add missing aria labels
5d519c9 
Signed-off-by: Vinicius Reis <[email protected]>
nextcloud-command pushed a commit that referenced this issue Jul 13, 2022
@nextcloud-command
⚡️ (#2387): remove events from $editor before destroy it
4fb9dbd 
Signed-off-by: Vinicius Reis <[email protected]>
Signed-off-by: nextcloud-command <[email protected]>
nextcloud-command pushed a commit that referenced this issue Jul 13, 2022
@vinicius73
♿️ (#2387): prevent focus to go back to file list
cc762b9 
Signed-off-by: Vinicius Reis <[email protected]>
nextcloud-command pushed a commit that referenced this issue Jul 13, 2022
@vinicius73
♿️ (#2387): add missing aria labels
0ab43fa 
Signed-off-by: Vinicius Reis <[email protected]>
vinicius73 pushed a commit that referenced this issue Jul 13, 2022
♿️ (#2387): add missing aria labels
07ddad4 
Signed-off-by: Vinicius Reis <[email protected]>
vinicius73 pushed a commit that referenced this issue Jul 13, 2022
♿️ (#2387): add missing aria labels
22213fd 
Signed-off-by: Vinicius Reis <[email protected]>
@juliusknorr juliusknorr moved this from 📄 To do (5-20 entries) to 🏗️ In progress in 📝 Office team Jul 14, 2022
nextcloud-command pushed a commit that referenced this issue Jul 15, 2022
@vinicius73
♿️ (#2387): prevent focus to go back to file list
608febe 
Signed-off-by: Vinicius Reis <[email protected]>
nextcloud-command pushed a commit that referenced this issue Jul 15, 2022
@vinicius73
♿️ (#2387): add missing aria labels
1cb2281 
Signed-off-by: Vinicius Reis <[email protected]>
@juliusknorr
Copy link
Member Author

juliusknorr pushed a commit that referenced this issue Jul 19, 2022
@juliusknorr
♿️ (#2387): add missing aria labels
0f1fe29 
Signed-off-by: Vinicius Reis <[email protected]>
nextcloud-command pushed a commit that referenced this issue Jul 19, 2022
@vinicius73
♿️ (#2387): add missing aria labels
87d6bf4 
Signed-off-by: Vinicius Reis <[email protected]>
@vinicius73
Copy link
Member

Scheduled to v5.3.2 https://github.com/nextcloud/nextcloud-vue/milestone/77

@juliusknorr
Copy link
Member Author

Done with #2794

Repository owner moved this from 🏗️ In progress to ☑️ Done in 📝 Office team Aug 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vinicius73 vinicius73

Labels
1. to develop accessibility bug Something isn't working
Projects
📝 Office team
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Prevent focus to go back to file list nextcloud/text
2 participants
@vinicius73 @juliusknorr