Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Formatting help modal needs some padding #5456

Closed
szaimen opened this issue Mar 11, 2024 · 0 comments · Fixed by #5488
Closed

Formatting help modal needs some padding #5456

szaimen opened this issue Mar 11, 2024 · 0 comments · Fixed by #5488
Labels
1. to develop bug Something isn't working design Experience, interaction, interface, …

Comments

@szaimen
Copy link
Contributor

szaimen commented Mar 11, 2024

Just tested on nc29.0.0b1, the formatting help modal needs some padding:
image
Another option might be migrating to ncdialog which might already fix it.
@szaimen szaimen added bug Something isn't working design Experience, interaction, interface, … 1. to develop labels Mar 11, 2024
@szaimen szaimen moved this to 🧭 Planning evaluation / ideas in 🖍 Design team Mar 11, 2024
@szaimen szaimen moved this from 🧭 Planning evaluation / ideas to 🕶️ Design review in 🖍 Design team Mar 11, 2024
mejo- added a commit that referenced this issue Mar 14, 2024
@mejo-
fix(HelpModal): Migrate to NcDialog, fix padding
4b4bdb5 
Fixes: #5456

Signed-off-by: Jonas <[email protected]>
@mejo- mejo- mentioned this issue Mar 14, 2024
Merged
2 tasks
@github-project-automation github-project-automation bot moved this from 🕶️ Design review to 🎉 Done in 🖍 Design team Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1. to develop bug Something isn't working design Experience, interaction, interface, …
Projects
🖍 Design team
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(HelpModal): Migrate to NcDialog, fix padding nextcloud/text
1 participant
@szaimen