Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Show rich workspaces" checkbox div has duplicit element ID #602

Closed
Disassembler0 opened this issue Jan 21, 2020 · 0 comments
Closed

"Show rich workspaces" checkbox div has duplicit element ID #602

Disassembler0 opened this issue Jan 21, 2020 · 0 comments
Assignees
@juliusknorr
Labels
2. developing bug Something isn't working
Milestone
18.0.1

Comments

@Disassembler0
Copy link

Describe the bug
"Show rich workspaces" checkbox and label is wrapped in div with ID files-setting-showhidden. This duplicates the ID already used for "Show hidden files" checkbox and breaks attempts to hide the control along with the whole unwanted rich workspaces feature as described in #586.

To Reproduce
Steps to reproduce the behavior:

  1. Go to "Files".
  2. Inspect element with "Show rich workspaces" checkbox.
  3. See that the wrapping div has the same ID as the div for "Show hidden files" checkbox.

Expected behavior
The div should have a unique ID.

Server details
Text app version: 2.0.0
Nextcloud version: 18.0.0
@Disassembler0 Disassembler0 added the bug Something isn't working label Jan 21, 2020
@juliusknorr juliusknorr self-assigned this Jan 22, 2020
@juliusknorr juliusknorr added this to the 18.0.1 milestone Jan 22, 2020
juliusknorr added a commit that referenced this issue Jan 24, 2020
@juliusknorr
Fix duplicate settings id (fixes #602)
2059a1b 
Signed-off-by: Julius Härtl <[email protected]>
@juliusknorr juliusknorr mentioned this issue Jan 24, 2020
Merged
juliusknorr added a commit that referenced this issue Jan 27, 2020
@juliusknorr
Fix duplicate settings id (fixes #602)
215e466 
Signed-off-by: Julius Härtl <[email protected]>
juliusknorr added a commit that referenced this issue Feb 4, 2020
@juliusknorr
Fix duplicate settings id (fixes #602)
a22b6c8 
Signed-off-by: Julius Härtl <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@juliusknorr juliusknorr

Labels
2. developing bug Something isn't working
Projects
None yet
Milestone
18.0.1
Development

No branches or pull requests
2 participants
@juliusknorr @Disassembler0