Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call userinfo on login to enrich the login ID token #1041

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

julien-nc
Copy link
Member

closes #1034

If, for some reason, some user information is missing from the login ID tokens but can be obtained with the userinfo endpoint, user_oidc can now optionally call the userinfo endpoint on login to enrich the data contained in the login ID token.

@jvllmr
Copy link

jvllmr commented Mar 7, 2025

I mentioned this on my issue before, but this change works well for me in on test setup ✅

@juliusknorr
Copy link
Member

Are we sure that we are properly requesting the additional information? I would expect that the extra claim for userinfo should be able to return that

// more details about requesting claims:
// https://openid.net/specs/openid-connect-core-1_0.html#IndividualClaimsRequests
// ['essential' => true] means it's mandatory but it won't trigger an error if it's not there
// null means we want it
'id_token' => [],
'userinfo' => [],

https://openid.net/specs/openid-connect-core-1_0.html#IndividualClaimsRequests

I'm not a fan of all the extra settings, so mostly asking if we know a reason why this is not sent right away.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provision groups from userinfo/introspection endpoints information
3 participants