Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow to delete files with a shortcut #1295

Merged
merged 1 commit into from
Aug 12, 2022
Merged

allow to delete files with a shortcut #1295

merged 1 commit into from
Aug 12, 2022

Conversation

szaimen
Copy link
Contributor

@szaimen szaimen commented Jul 18, 2022 •
edited
Loading

Close #897

Signed-off-by: szaimen [email protected]

For my own testing 
docker run -it \
-p 8443:443 \
-e VIEWER_BRANCH=enh/noid/shortcut-delete \
-e TRUSTED_DOMAIN=192.168.146.130 \
--name nextcloud-easy-test \
ghcr.io/szaimen/nextcloud-easy-test:latest

@szaimen szaimen added the 2. developing Work in progress label Jul 18, 2022
@szaimen szaimen added this to the Nextcloud 25 milestone Jul 18, 2022
@szaimen szaimen requested a review from artonge July 18, 2022 21:50
@szaimen szaimen marked this pull request as draft July 18, 2022 22:22
@szaimen szaimen force-pushed the enh/noid/shortcut-delete branch 2 times, most recently from 333434d to 6c5eb0b Compare July 18, 2022 22:32
@nextcloud-command nextcloud-command force-pushed the enh/noid/shortcut-delete branch from 6c5eb0b to 889781a Compare July 19, 2022 01:07
@szaimen szaimen force-pushed the enh/noid/shortcut-delete branch from 889781a to d51f0b7 Compare August 11, 2022 23:58
@szaimen
Copy link
Contributor Author

szaimen commented Aug 11, 2022

/compile amend /

@szaimen szaimen marked this pull request as ready for review August 11, 2022 23:59
@szaimen szaimen requested a review from skjnldsv August 11, 2022 23:59
@szaimen szaimen added enhancement New feature or request 3. to review Waiting for reviews and removed 2. developing Work in progress labels Aug 11, 2022
@szaimen szaimen requested a review from Pytal August 11, 2022 23:59
@szaimen @nextcloud-command
allow to delete files with a shortcut
614ec6d 
Signed-off-by: szaimen <[email protected]>
Signed-off-by: nextcloud-command <[email protected]>
@nextcloud-command nextcloud-command force-pushed the enh/noid/shortcut-delete branch from d51f0b7 to 614ec6d Compare August 12, 2022 00:00
@Pytal Pytal added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Aug 12, 2022
@Pytal Pytal merged commit 3cb712f into master Aug 12, 2022
@Pytal Pytal deleted the enh/noid/shortcut-delete branch August 12, 2022 01:12
@skjnldsv skjnldsv mentioned this pull request Aug 12, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artonge artonge artonge approved these changes

@Pytal Pytal Pytal approved these changes

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish enhancement New feature or request
Projects
None yet
Milestone
Nextcloud 25
Development

Successfully merging this pull request may close these issues.

Delete image with del button
3 participants
@szaimen @artonge @Pytal