Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable24] Merge pull request #1273 from nextcloud/enh/open_with #1296

Merged
merged 3 commits into from
Jul 21, 2022

Conversation

Raudius
Copy link
Contributor

@Raudius Raudius commented Jul 20, 2022

Manual backport for: #1273

Add openWith function to OCA.Viewer

@Raudius Raudius force-pushed the backport24/open_with branch 2 times, most recently from bc2e116 to df292ba Compare July 20, 2022 08:55
@Raudius Raudius changed the title Merge pull request #1273 from nextcloud/enh/open_with [stable24] Merge pull request #1273 from nextcloud/enh/open_with Jul 20, 2022
@Raudius Raudius requested review from julien-nc and juliusknorr July 20, 2022 09:44
@Raudius Raudius added enhancement New feature or request 3. to review Waiting for reviews labels Jul 20, 2022
@juliusknorr juliusknorr added bug Something isn't working and removed enhancement New feature or request labels Jul 20, 2022
@juliusknorr
Copy link
Member

@Raudius Just noticed, It would be nice to have the commits being cherry-picked instead of the merge commit, so we preserve the original commit details. :)

@juliusknorr juliusknorr added this to the Nextcloud 24.0.4 milestone Jul 20, 2022
Raudius and others added 2 commits July 21, 2022 06:40
Signed-off-by: Raul <[email protected]>
Signed-off-by: nextcloud-command <[email protected]>
Signed-off-by: Julien Veyssier <[email protected]>
Signed-off-by: nextcloud-command <[email protected]>
@Raudius Raudius force-pushed the backport24/open_with branch 2 times, most recently from fd01521 to ea7121d Compare July 21, 2022 05:44
Signed-off-by: Julius Härtl <[email protected]>
@Raudius Raudius force-pushed the backport24/open_with branch from ea7121d to ddecad6 Compare July 21, 2022 06:20
@Raudius
Copy link
Contributor Author

Raudius commented Jul 21, 2022

@juliushaertl

Fixed the commits. Also fixed the pipeline, but I had to do an npm update which messed results in a big diff on the .lock, do you know why this might be?

@juliusknorr
Copy link
Member

Fixed the commits. Also fixed the pipeline, but I had to do an npm update which messed results in a big diff on the .lock, do you know why this might be?

npm update shouldn't be required. npm ci would install the dependencies on the current branch based on what is stated in the package-lock.json file. Do you remember what lead to running npm update?

@juliusknorr juliusknorr merged commit a280176 into stable24 Jul 21, 2022
@juliusknorr juliusknorr deleted the backport24/open_with branch July 21, 2022 07:56
@Raudius Raudius mentioned this pull request Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants