fix: do not use removed View::getLocalFolder() #174
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #171
Well, in theory. In practice, there is still a check that prevents workflow_script actions running against folders:
https://github.com/nextcloud/workflow_script/blob/master/lib/Operation.php#L148
That was mentioned once in a bug report, I am sure. We might have it because flows may run against the target file and the parent. It is not good to generally take out folders here. But for a different PR.
But let's say we do not have this restriction. Then, compared to 26 where
getLocalFolderwas present, these changes actually fix an uncaught exception against non-local storages, where the method is not implemented. Now they are ignored, which at least is smooth and not interrupting the actual action.Also, this was problematic for shared storages (only the user folder of the owner was returned), alas here we have an issue as well with both the owner and the recipient being part of the resulting path.
Due to the previously mentioned restriction against folder, this is not a blocker per se for 27, nevertheless good to get it in in this form at least.
Update: I am thinking this might be simply dropped for Folders in general, as there is no support across storages and it never was working anyway due to the non-folder restriction pointed out. Now, this seems very much the better idea anyway for the actual purpose was to offer a external files locally.