Error & info messages, code comments language fixes part 1 #3475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llewellyn-sl
changed the title
abhi18av
approved these changes
Dec 7, 2022
There was a problem hiding this comment.
Looking good @llewellyn-sl , are you planning to continue working on this PR w.r.t the entire codebase or this is ready to be merged?
@abhi18av thanks for reviewing. I'm working my way through the entire codebase, but this is going to be stretched across the next few weeks. I think it would be best to do this in chapters with separate PRs each time. |
pditommaso
force-pushed
the
master
branch
2 times, most recently
from
e2b4a93 to
f32ea0b
Compare
pditommaso
reviewed
Dec 11, 2022
…[ci skip] Signed-off-by: Paolo Di Tommaso <[email protected]>
pditommaso
reviewed
Dec 11, 2022
modules/nextflow/src/main/groovy/nextflow/file/DirWatcherV2.groovy
Outdated
Show resolved
Hide resolved
…oovy [ci skip] Signed-off-by: Paolo Di Tommaso <[email protected]>
pditommaso
reviewed
Dec 11, 2022
…[ci skip] Signed-off-by: Paolo Di Tommaso <[email protected]>
l-modolo
pushed a commit
to l-modolo/nextflow
that referenced
this pull request
Jan 25, 2023
Signed-off-by: Paolo Di Tommaso <[email protected]> Co-authored-by: Paolo Di Tommaso <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.