Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused DSL syntax #3671

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Conversation

bentsherman
Copy link
Member

@bentsherman bentsherman commented Feb 21, 2023

Third batch of changes from #3344 . This PR removes some unused code related to DSL syntax:

  • remove old module include syntax
  • remove from / into syntax for process inputs/outputs
  • remove old process named args syntax
  • remove set qualifier for process inputs/outputs

@pditommaso pditommaso force-pushed the master branch 2 times, most recently from 0d59b4c to b93634e Compare March 11, 2023 11:20
@bentsherman bentsherman changed the title Remove deprecated code (part 3) Remove deprecated DSL syntax Apr 21, 2023
@bentsherman bentsherman linked an issue May 8, 2023 that may be closed by this pull request
@pditommaso pditommaso force-pushed the master branch 2 times, most recently from 81f7cb7 to 8a43489 Compare August 20, 2023 20:13
@netlify
Copy link

netlify bot commented Sep 18, 2023

Deploy Preview for nextflow-docs-staging canceled.

Name Link
🔨 Latest commit 80d957d
🔍 Latest deploy log https://app.netlify.com/sites/nextflow-docs-staging/deploys/660b1d646cf34f0008245101

@bentsherman bentsherman changed the title Remove deprecated DSL syntax Remove unused DSL syntax Dec 4, 2023
@bentsherman
Copy link
Member Author

Okay @pditommaso this PR is ready to go. Now that I have a much deeper understanding of the AST transforms, I'm confident these changes only remove dead code from the DSL1 syntax.

With these simplifications I was able to improve the error checking for process inputs and outputs. So we don't need the hack from #4085 anymore because we can catch it during compilation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DSL1 warning remains
2 participants