more clear explanation about splitCsv() operators #4163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jesse <[email protected]>
✅ Deploy Preview for nextflow-docs-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Fwiw I think I have done this in #3959 |
|
Thank you for your mention. But I did not find your pull request related with mine. Do you think my pr can be merge |
pditommaso
force-pushed
the
master
branch
2 times, most recently
from
81f7cb7 to
8a43489
Compare
pditommaso
reviewed
Sep 3, 2023
Signed-off-by: Paolo Di Tommaso <[email protected]>
abhi18av
pushed a commit
to abhi18av/nextflow
that referenced
this pull request
Oct 28, 2023
Signed-off-by: Jesse <[email protected]> Signed-off-by: Paolo Di Tommaso <[email protected]> Co-authored-by: Paolo Di Tommaso <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From the provided official documentation, I noticed that the description of how the
.splitCsv()operation handles CSV data and the nature of its returned data structures is somewhat ambiguous. The documentation showcases examples with and without theheaderparameter, but it doesn't explicitly mention the exact type of returned data (ListvsLinkedHashMap).I believe that such clarity would be invaluable to readers aiming to understand the
.splitCsv()operation fully. For the sake of clarity and comprehensiveness in the documentation, I propose the following clarifications:**- If the header option is not used, .splitCsv() returns each row as a List.
Incorporating this information into the official documentation would offer readers a more lucid and actionable understanding.