Add check for latest version #4194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paolo Di Tommaso <[email protected]>
✅ Deploy Preview for nextflow-docs-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Can we put it under a CLI option? |
|
Think as a user you may want to disable it more once for all system-wide |
|
So an environment variable? Makes sense |
|
Yep, an env variable. |
|
I just realized you already had the env variable... should have read the entire PR 🤦 |
bentsherman
approved these changes
Aug 17, 2023
|
If you don't like how long the HTTP request takes, then I would just switch the env variable to enable it rather than disable it. |
|
Think it's mostly related to my slow connection. Can you please give it a try? |
# check for update
- check_latest
+ time check_latest$ for i in `seq 10`; do nextflow info 2>&1 | grep real ; done
real 0m0.112s
real 0m0.075s
real 0m0.072s
real 0m0.081s
real 0m0.070s
real 0m0.070s
real 0m0.084s
real 0m0.073s
real 0m0.075s
real 0m0.074s |
pditommaso
force-pushed
the
master
branch
2 times, most recently
from
81f7cb7 to
8a43489
Compare
Signed-off-by: Paolo Di Tommaso <[email protected]>
abhi18av
pushed a commit
to abhi18av/nextflow
that referenced
this pull request
Oct 28, 2023
Signed-off-by: Paolo Di Tommaso <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the check for latest version of Nextflow on startup, printing a notification message is available.
The check can be disabled using the env variable
NXF_DISABLE_CHECK_LATEST.However, with some basic test it looks like it takes ~4-500ms for a simple http request, which is too slow.