-
Notifications
You must be signed in to change notification settings - Fork 659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate process shell
block
#5508
Conversation
Signed-off-by: Ben Sherman <[email protected]>
✅ Deploy Preview for nextflow-docs-staging canceled.
|
Signed-off-by: Ben Sherman <[email protected]>
Signed-off-by: Ben Sherman <[email protected]>
It would make sense to add a deprecation warning (and a warning to disable it) |
Signed-off-by: Ben Sherman <[email protected]>
Can we clarify the behavior of single ( |
modules/nextflow/src/main/groovy/nextflow/ast/NextflowDSLImpl.groovy
Outdated
Show resolved
Hide resolved
Just my two cents: I use most of the time the terminal to work on Nextflow files, and I think it's still useful to easily distinguish between Nextflow and Bash variables. |
@christopher-hakkaart I will address single vs double quotes in the other PR, but I believe |
Signed-off-by: Ben Sherman <[email protected]>
I'm not sure if vim supports LSP but they just added the nextflow language server to neovim |
modules/nextflow/src/main/groovy/nextflow/ast/NextflowDSLImpl.groovy
Outdated
Show resolved
Hide resolved
Signed-off-by: Ben Sherman <[email protected]>
modules/nextflow/src/main/groovy/nextflow/processor/TaskProcessor.groovy
Outdated
Show resolved
Hide resolved
…sor.groovy Co-authored-by: Paolo Di Tommaso <[email protected]> Signed-off-by: Ben Sherman <[email protected]>
Thanks for the info. I think I've just been very happy with the fact that you don't need a special editor or editor plugin to work on Nextflow files. I will have a closer look at neovim. |
Based on some recent internal discussions. The original purpose of the
shell
block was to help distinguish between Nextflow and Bash variables in the process script. Since the VS Code extension now provides both syntax highlighting and error checking for variable names, theshell
block isn't needed as much and can be phased out to promote consistent code.I didn't bother to add a warning in the code because I will add one in the language server, but we can add one here if you want.