Ensure job is killed when exception in task status check #5561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jorgee <[email protected]>
Closed
✅ Deploy Preview for nextflow-docs-staging canceled.
|
pditommaso
reviewed
Dec 3, 2024
modules/nextflow/src/main/groovy/nextflow/processor/TaskPollingMonitor.groovy
Outdated
Show resolved
Hide resolved
Signed-off-by: jorgee <[email protected]>
Signed-off-by: Paolo Di Tommaso <[email protected]>
|
Depends on #5594 |
Improve kill task logic
bentsherman
approved these changes
Dec 10, 2024
pditommaso
reviewed
Dec 11, 2024
Signed-off-by: jorgee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there is some exception in the task status check code, notifyError is called and the job is removed from the running queue preventing to be killed when doing the cleanup at abort.
The modification ensures the job is killed when no controlled process failures are notified.