Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update annotation schema for strand changes #1279

Closed
wants to merge 1 commit into from

Conversation

victorlin
Copy link
Member

Description of proposed changes

Related issue(s)

Follow-up to #1211 and #966 (comment).

Testing

  • Add new tests

Checklist

  • Add a message in CHANGES.md summarizing the changes in this PR that are end user focused. Keep headers and formatting consistent with the rest of the file.

This is a follow-up to 31f0b26, where
possible values were updated.
@victorlin victorlin self-assigned this Aug 11, 2023
@jameshadfield
Copy link
Member

Conversation moved from #1281 (comment):

Entries in the annotations JSON (except "nuc") correspond to translated CDSs, and are interpreted by Auspice as such. In this context, it makes no sense to be strandless / unknown-strand. As of nextstrain/auspice#1684, Auspice will skip any entry if the strand is not "+"/"-".

If we want to extend our concept of annotations to include features beyond CDSs then it makes sense to include these, although I'd prefer we use GFF syntax for the enum values. However I'm not sure what we'd do with these features -- we can't translate them, and Auspice can't (currently) display them. One potential example of us doing this would be nextstrain/auspice#1686, which I think in GFF terms would be represented as a strandless feature, but I think we'll encode it as a sub-feature of the CDS.

@genehack
Copy link
Contributor

@victorlin sounds like this was a non-starter, can this PR be closed out?

@victorlin victorlin closed this Jan 13, 2025
@victorlin victorlin deleted the victorlin/update-translate-strand branch January 13, 2025 23:17
@victorlin
Copy link
Member Author

My confusion here was the disconnect between the values that Augur exports and values that Auspice can handle. That's since been properly handled by this additional warning in #1438:

augur/augur/utils.py

Lines 885 to 886 in 1843a9b

elif annotations[fname]['strand'] not in ['+', '-']:
print(f"WARNING: Feature '{fname}' uses a strand which auspice cannot display")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

3 participants