ancestral: Accept files to --genes
#1353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
victorlin
force-pushed
the
victorlin/genes-file
branch
3 times, most recently
from
fe247f8 to
f59f180
Compare
tests/functional/ancestral/cram/infer-amino-acid-sequences-genes-file.t
Outdated
Show resolved
Hide resolved
victorlin
force-pushed
the
victorlin/genes-file
branch
2 times, most recently
from
a60f1a6 to
939d2cb
Compare
victorlin
force-pushed
the
victorlin/genes-file
branch
from
35eb0e2 to
27b5bf7
Compare
victorlin
force-pushed
the
victorlin/genes-file
branch
2 times, most recently
from
01f9b69 to
bf7a17a
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1353 +/- ##
=======================================
Coverage 66.23% 66.23%
=======================================
Files 68 69 +1
Lines 7238 7248 +10
Branches 1780 1778 -2
=======================================
+ Hits 4794 4801 +7
- Misses 2176 2179 +3
Partials 268 268 ☔ View full report in Codecov by Sentry. |
victorlin
force-pushed
the
victorlin/deprecated-file
branch
from
e6c2fe4 to
8862cfe
Compare
victorlin
force-pushed
the
victorlin/genes-file
branch
from
bf7a17a to
408baeb
Compare
This can be used in other contexts where newline-delimited entries from a text file are useful.
This allows future re-use.
Previously, the help text for --genes falsely claimed that it could accept a file. Now, it can truly claim that. Move the file parsing functions to utils.
victorlin
force-pushed
the
victorlin/genes-file
branch
from
408baeb to
03f27ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Implements a feature claimed by help output, rearranging some code along the way.
Related issue(s)
read_strainsmove: Refine scope of Augur's Python Development API #1011Checklist