Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NXtomo] Need user flags #762

Closed
vasole opened this issue Mar 5, 2020 · 4 comments
Closed

[NXtomo] Need user flags #762

vasole opened this issue Mar 5, 2020 · 4 comments
Labels
Milestone

Comments

@vasole
Copy link
Contributor

vasole commented Mar 5, 2020

The NXtomo definition foresees three flags in the image_key dataset (projection = 0, flat field = 1, dark field = 2, invalid = 3). We need to add some additional keys to indicate other uses (for instance control images).

When dealing with detectors, the possibility to use user_defined masks was foreseen but it is not the case for this definition. We would not like to take a number that later on is used by NeXus. Because of that we have started to use negative numbers to indicate user specific meaning. Could that approach (flags smaller than 0 are available for the user) be officially endorsed or an alternative suggested?

@vasole vasole added the question label Mar 5, 2020
@vasole
Copy link
Contributor Author

vasole commented Mar 5, 2020

By an alternative I mean things like flags bigger than XX are free for the user.

@mkoennecke
Copy link
Contributor

mkoennecke commented Mar 6, 2020 via email

@vasole
Copy link
Contributor Author

vasole commented Mar 6, 2020

If to add control frames is a common practice, then I agree it would be best to add an additional number.

@benajamin
Copy link
Contributor

This was discussed in the April 2020 telco. We agreed that reserving negative image keys for user-defined cases is a good strategy, but there should also be additional fields (perhaps in a groups to collect them together) to provide a standardised method to record the meaning of these keys. An example could be:
user_keys:NXgroup
minus_1: NXnote - "timing control"
minus_2:NXnote - "laser pulse"

We recommend writing a NIAC proposal for amending the NXtomo application definition in such a manner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants