Clarify how beam_center_x and beam_center_y are used #682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n field is not present
|
@zjttoefs - Do you have time review this before Friday? |
|
@zjttoefs -- review today? |
|
I'll merge this evening unless there is an objection. |
|
If you have no axis chain, you can still process data if you have the beam
center, wavelength and detector distance and
assume a simple head-on detector orientation. That is what allows people
to process miniCBF Pilatus images and
Eiger images with most of the metadata missing. Unfortunately it also
leads to lots of mistakes and mis-processed
images, which is why much of the MX community has decided to push for more
complete metadata.
…On Mon, Sep 9, 2019 at 5:10 PM Aaron S. Brewster ***@***.***> wrote:
beam_center_x and beam_center_y are only used if the depends_on field is
not present. Clarify this and provide a definition of the default geometry
given no dependency chain.
------------------------------
You can view, comment on, or merge this pull request online at:
#682
Commit Summary
- Clarify how beam_center_x and beam_center_y are used if the
depends_on field is not present
File Changes
- *M* applications/NXmx.nxdl.xml
<https://github.com/nexusformat/definitions/pull/682/files#diff-0>
(16)
Patch Links:
- https://github.com/nexusformat/definitions/pull/682.patch
- https://github.com/nexusformat/definitions/pull/682.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#682?email_source=notifications&email_token=ABB6EANLFVCKFURGAV7FH4LQI23TPA5CNFSM4IVAGBXKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HKJCNWA>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABB6EAPBYSHE6XXYZ2W6QR3QI23TPANCNFSM4IVAGBXA>
.
|
|
@yayahjb - Are you implying this needs more discussion and should not be merged at this time? |
|
Yes this needs more discussion, but the proposed merge is a useful step in
the right direction. When we bring the
Gold Standard to NIAC we well may improve this wording and introduce an
additional tag to allow finer control
over processing in cases where both an axis chain and beam center are
provided.
…-- Herbert
On Thu, Jan 30, 2020 at 4:59 PM Pete R Jemian ***@***.***> wrote:
@yayahjb <https://github.com/yayahjb> - Are you implying this needs more
discussion and should not be merged at this time?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#682?email_source=notifications&email_token=ABB6EAL66I6WZ7CHXO5PLT3RANEUPA5CNFSM4IVAGBXKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKMW7ZI#issuecomment-580480997>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABB6EAJFDAR2D26DXVQ3MVDRANEUPANCNFSM4IVAGBXA>
.
|
|
OK, I will move this to a later milestone. |
zjttoefs
approved these changes
Jun 4, 2020
|
I agree, this is probably not the last word on the matter. But the PR helps clarify what we know and agree on. |
|
Thanks. Merging. |
|
Thanks, all. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
beam_center_x and beam_center_y are only used if the depends_on field is not present. Clarify this and provide a definition of the default geometry given no dependency chain.