document plot title and axis labels #761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
@vasole: Can you click the Approve button for your GitHub review? |
|
The information is fine but the tests do not pass. |
|
No approve button available |
vasole
approved these changes
Feb 25, 2020
|
Done, |
|
Thanks. I see the reST/sphinx syntax error now. |
|
The syntax error was with XML, the reST/Sphinx syntax was correct. When reST is embedded within an XML document, as is our documentation of NXDL structure, we can't use |
|
Looks good to me too. |
rayosborn
approved these changes
Feb 25, 2020
|
Feel free to merge when you feel ready (either of you). Might wait a couple days if there are comments from there. |
|
No additional comments received, merging now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addition of a
titlefield to NXdata and additional documentation fixes #760, where it was asked how to find the plot title in the NeXus data file structure.