Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NXsnsevent and NXsnshisto: deprecate _error fields #825

Merged
merged 3 commits into from
Oct 19, 2020
Merged

NXsnsevent and NXsnshisto: deprecate _error fields #825

merged 3 commits into from
Oct 19, 2020

Conversation

phyy-nx
Copy link
Contributor

@phyy-nx phyy-nx commented Oct 19, 2020

Fixes #821

@phyy-nx phyy-nx marked this pull request as ready for review October 19, 2020 17:59
@phyy-nx phyy-nx mentioned this pull request Oct 19, 2020
Closed
@prjemian prjemian added this to the NXDL 2020.10 milestone Oct 19, 2020
@phyy-nx phyy-nx requested a review from a team October 19, 2020 18:22
prjemian
prjemian approved these changes Oct 19, 2020
View reviewed changes
Copy link
Contributor

@prjemian prjemian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yayahjb yayahjb merged commit bf6702f into master Oct 19, 2020
@phyy-nx phyy-nx deleted the fix_821_deprecate_error branch October 19, 2020 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prjemian prjemian prjemian approved these changes

@yayahjb yayahjb yayahjb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
NXDL 2020.10
Development

Successfully merging this pull request may close these issues.

adjust NXsnsevent and NXsnshisto to be consistent with #634
3 participants
@phyy-nx @prjemian @yayahjb