Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add _errors to NXreflections #859

Merged
merged 1 commit into from
Nov 3, 2020
Merged

Add _errors to NXreflections #859

merged 1 commit into from
Nov 3, 2020

Conversation

phyy-nx
Copy link
Contributor

@phyy-nx phyy-nx commented Oct 27, 2020

Fixes #724

Considered deprecating the _var fields but I'm not convinced there is a need too, even though the spec did get a bit busy through this change.

@phyy-nx phyy-nx requested a review from yayahjb October 27, 2020 19:57
yayahjb
yayahjb approved these changes Nov 3, 2020
View reviewed changes
Copy link
Contributor

@yayahjb yayahjb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am approving, but I agree with Pete's comment that this had gotten rather busy and suggest we revisit for a clean-up in a year or so.

@prjemian prjemian merged commit 98a25a5 into master Nov 3, 2020
@prjemian prjemian deleted the nxreflections_errors_724 branch November 3, 2020 13:59
@PeterC-DLS PeterC-DLS added this to the NXDL 2020.10 milestone Dec 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yayahjb yayahjb yayahjb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
NXDL 2020.10
Development

Successfully merging this pull request may close these issues.

Consider changing _var to _errors in NXreflections
4 participants
@phyy-nx @yayahjb @PeterC-DLS @prjemian