Posible fix for issue #127 #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dev -> master with subway fixes
Dev -> master for v1.1.1
Dev -> master for v1.2.0
|
pinin4fjords
approved these changes
May 11, 2023
There was a problem hiding this comment.
Looks sensible- thanks for the fix!
I’d normally object to lots of random spacing changes unrelated to the fix (presumably from your IDE), but it mostly seems to be rogue spaces being removed (@WackerO will be happy), and it’s come up before, so we’ll allow it ;-).
|
Ahh, wait, @ctuni - could you add the file existence check before you merge? |
pinin4fjords
requested changes
May 11, 2023
pinin4fjords
requested changes
May 11, 2023
|
HI! I'm sorry for the IDE and whitespaces thing, I did not realized it happened when pulling. I can try and re-do the PR with it but thanks for allowing it! I added the file existence check also :) |
No, don’t worry, @WackerO had the same issue before, and the changes are harmless. Thanks for the fix. |
|
Well this is brilliant :D I was asking Cris to remove the whitespaces because I sensed a disturbance in the force and predicted your objection, @pinin4fjords! But yes, I am happy ^^ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#127 This is a possible fix for the aforementioned issue. I tested both with
-profile test,dockerand with my data and infrastructure and the process that was failing on my case (VALIDATOR) is no longer failing. Thetestprofile was not failing but it's working correctly with the fix also.The change is made in the creation of
ch_inputchannel, just addingfile()aroundparams.input. Apparently, this way the input matrix can be read as a file and it does not throw the error.This change is made in line 17 of
differentialabundance.nffile.PR checklist
nf-core lint).nextflow run . -profile test,docker --outdir <OUTDIR>).