Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve gtf to table configurability #131

Merged
merged 6 commits into from
May 25, 2023

Conversation

pinin4fjords
Copy link
Member

@pinin4fjords pinin4fjords commented May 25, 2023

No description provided.

@github-actions
Copy link

This PR is against the master branch ❌

  • Do not close this PR
  • Click Edit and change the base to dev
  • This CI test will remain failed until you push a new commit

Hi @pinin4fjords,

It looks like this pull-request is has been made against the pinin4fjords/differentialabundance master branch.
The master branch on nf-core repositories should always contain code from the latest release.
Because of this, PRs to master are only allowed if they come from the pinin4fjords/differentialabundance dev branch.

You do not need to close this PR, you can change the target branch to dev by clicking the "Edit" button at the top of this page.
Note that even after this, the test will continue to show as failing until you push a new commit.

Thanks again for your contribution!

@github-actions
Copy link

github-actions bot commented May 25, 2023

nf-core lint overall result: Passed ✅

Posted for pipeline commit bafb03f

+| ✅ 160 tests passed       |+

✅ Tests passed:

Run details

  • nf-core/tools version 2.8
  • Run at 2023-05-25 11:00:45

@pinin4fjords pinin4fjords changed the base branch from master to dev May 25, 2023 09:53
Copy link
Collaborator

@WackerO WackerO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pinin4fjords
Copy link
Member Author

Thanks @WackerO !

@pinin4fjords pinin4fjords merged commit 18e7735 into nf-core:dev May 25, 2023
@pinin4fjords pinin4fjords deleted the improve_gtf_config branch May 25, 2023 11:14
@pinin4fjords pinin4fjords added this to the 1.3.0 milestone Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants