Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump gtf2featureannotation to fix GTF handling error #259

Merged
merged 3 commits into from
Apr 10, 2024
Merged

Bump gtf2featureannotation to fix GTF handling error #259

merged 3 commits into from
Apr 10, 2024

Conversation

pinin4fjords
Copy link
Member

Just bumping the gtf2featureannotation module to fix problems with error messages when handling GTFs.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/differentialabundance branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@pinin4fjords pinin4fjords changed the title Bump gtf2featureannotation Bump gtf2featureannotation to fix GTF handling error Apr 9, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 9, 2024 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 6e158cb

+| ✅ 271 tests passed       |+
!| ❗   5 tests had warnings |!

❗ Test warnings:

  • nextflow_config - Config manifest.version should end in dev: 1.5.0
  • pipeline_todos - TODO string in awsfulltest.yml: You can customise AWS full pipeline tests as required
  • pipeline_todos - TODO string in main.nf: Optionally add in-text citation tools to this list.
  • pipeline_todos - TODO string in main.nf: Optionally add bibliographic entries to this list.
  • pipeline_todos - TODO string in main.nf: Only uncomment below if logic in toolCitationText/toolBibliographyText has been filled!

✅ Tests passed:

Run details

  • nf-core/tools version 2.13.1
  • Run at 2024-04-09 18:22:40

@pinin4fjords pinin4fjords merged commit 314ee61 into dev Apr 10, 2024
12 checks passed
@pinin4fjords pinin4fjords deleted the update_gtf2featureannotation branch April 10, 2024 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WackerO WackerO WackerO approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pinin4fjords @WackerO