Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logging by specifying assays to log #266

Merged
merged 11 commits into from
May 7, 2024
Merged
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### `Added`

- [[#266](https://github.com/nf-core/differentialabundance/pull/266)] - Fix logging by specifying assays to log ([@pinin4fjords](https://github.com/pinin4fjords), review by [@WackerO](https://github.com/WackerO))
- [[#259](https://github.com/nf-core/differentialabundance/pull/259)] - Bump gtf2featureannotation to fix GTF handling error ([@pinin4fjords](https://github.com/pinin4fjords), review by [@WackerO](https://github.com/WackerO))
- [[#257](https://github.com/nf-core/differentialabundance/pull/257)] - Added maxquant profile to nextflow.config to make it available ([@WackerO](https://github.com/WackerO), review by [@pinin4fjords](https://github.com/pinin4fjords))
- [[#254](https://github.com/nf-core/differentialabundance/pull/254)] - Some parameter changes, added qbic credits ([@WackerO](https://github.com/WackerO), review by [@pinin4fjords](https://github.com/pinin4fjords))
Expand Down
9 changes: 5 additions & 4 deletions assets/differentialabundance_report.Rmd
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ params:
features_metadata_cols: NULL
features_gtf_feature_type: NULL
features_gtf_table_first_field: NULL
features_log2_assays: NULL
exploratory_log2_assays: NULL
raw_matrix: null # e.g. 0_salmon.merged.gene_counts_length_scaled.tsv
normalised_matrix: null
variance_stabilised_matrix: null # e.g. test_files/3_treatment-WT-P23H.vst.tsv
Expand Down Expand Up @@ -310,11 +310,12 @@ assay_data <- lapply(assay_files, function(x) {
mat
})

if (!is.null(params$features_log2_assays)) {
log2_assays <- params$exploratory_log2_assays
if (!is.null(log2_assays)) {
# Remove brackets from assay list. TODO: remove if this is added to cond_log2_transform_assays
params$features_log2_assays <- gsub('\\]$', '', gsub('^\\[', '', params$features_log2_assays))
log2_assays <- gsub('\\]$', '', gsub('^\\[', '', log2_assays))
}
assay_data <- cond_log2_transform_assays(assay_data, params$features_log2_assays)
assay_data <- cond_log2_transform_assays(assay_data, log2_assays, prettify_names = FALSE)

# Now we can rename the observations rows using the title field
rownames(observations) <- observations[[observations_name_col]]
Expand Down
1 change: 1 addition & 0 deletions conf/affy.config
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ params {
// Exploratory
exploratory_assay_names = 'raw,normalised'
exploratory_final_assay = 'normalised'
exploratory_log2_assays = null

// Differential options
differential_file_suffix = ".limma.results.tsv"
Expand Down
1 change: 1 addition & 0 deletions conf/maxquant.config
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ params {
// Exploratory
exploratory_assay_names = "raw,normalised"
exploratory_final_assay = "normalised"
exploratory_log2_assays = null

// Differential options
differential_file_suffix = ".limma.results.tsv"
Expand Down
6 changes: 3 additions & 3 deletions conf/modules.config
Original file line number Diff line number Diff line change
Expand Up @@ -375,7 +375,7 @@ process {
"--final_assay \"${params.exploratory_final_assay}\"",
"--outlier_mad_threshold ${params.exploratory_mad_threshold}",
"--palette_name \"${params.exploratory_palette_name}\"",
( (params.study_type == 'maxquant') ? "--log2_assays ''" : (((params.features_log2_assays == null) ? '' : "--log2_assays \"$params.features_log2_assays\"".replace('[', '').replace(']', ''))) )
( (params.study_type == 'maxquant') ? "--log2_assays ''" : (((params.exploratory_log2_assays == null) ? '' : "--log2_assays \"$params.exploratory_log2_assays\"".replace('[', '').replace(']', ''))) )
].join(' ').trim() }
}

Expand Down Expand Up @@ -428,8 +428,8 @@ process {
}

withName: RMARKDOWNNOTEBOOK {
conda = "bioconda::r-shinyngs=1.8.4"
container = { "${ workflow.containerEngine == 'singularity' && !task.ext.singularity_pull_docker_container ? 'https://depot.galaxyproject.org/singularity/r-shinyngs:1.8.4--r43hdfd78af_0' : 'biocontainers/r-shinyngs:1.8.4--r43hdfd78af_0' }" }
conda = "bioconda::r-shinyngs=1.8.8"
container = { "${ workflow.containerEngine == 'singularity' && !task.ext.singularity_pull_docker_container ? 'https://depot.galaxyproject.org/singularity/r-shinyngs:1.8.8--r43hdfd78af_0' : 'biocontainers/r-shinyngs:1.8.8--r43hdfd78af_0' }" }
publishDir = [
[
path: { "${params.outdir}/report" },
Expand Down
1 change: 1 addition & 0 deletions conf/rnaseq.config
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ params {
// Exploratory
exploratory_assay_names = "raw,normalised,variance_stabilised"
exploratory_final_assay = "variance_stabilised"
exploratory_log2_assays = 'raw,normalised'

// Differential options
differential_file_suffix = ".deseq2.results.tsv"
Expand Down
1 change: 1 addition & 0 deletions conf/soft.config
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ params {
// Exploratory
exploratory_assay_names = 'normalised'
exploratory_final_assay = 'normalised'
exploratory_log2_assays = null

// Differential options
differential_file_suffix = ".limma.results.tsv"
Expand Down
10 changes: 5 additions & 5 deletions modules.json
Original file line number Diff line number Diff line change
Expand Up @@ -72,22 +72,22 @@
},
"shinyngs/app": {
"branch": "master",
"git_sha": "d2d6072ae4c3a9d394dfe773bb0751f34df7a896",
"git_sha": "85519fe9deccf2c5f7ff1f3b5d3494c61a794643",
"installed_by": ["modules"]
},
"shinyngs/staticdifferential": {
"branch": "master",
"git_sha": "d2d6072ae4c3a9d394dfe773bb0751f34df7a896",
"git_sha": "85519fe9deccf2c5f7ff1f3b5d3494c61a794643",
"installed_by": ["modules"]
},
"shinyngs/staticexploratory": {
"branch": "master",
"git_sha": "d2d6072ae4c3a9d394dfe773bb0751f34df7a896",
"git_sha": "85519fe9deccf2c5f7ff1f3b5d3494c61a794643",
"installed_by": ["modules"]
},
"shinyngs/validatefomcomponents": {
"branch": "master",
"git_sha": "d2d6072ae4c3a9d394dfe773bb0751f34df7a896",
"git_sha": "85519fe9deccf2c5f7ff1f3b5d3494c61a794643",
"installed_by": ["modules"]
},
"untar": {
Expand All @@ -111,7 +111,7 @@
},
"utils_nfcore_pipeline": {
"branch": "master",
"git_sha": "5caf7640a9ef1d18d765d55339be751bb0969dfa",
"git_sha": "92de218a329bfc9a9033116eb5f65fd270e72ba3",
"installed_by": ["subworkflows"]
},
"utils_nfvalidation_plugin": {
Expand Down
2 changes: 1 addition & 1 deletion modules/nf-core/shinyngs/app/environment.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

21 changes: 18 additions & 3 deletions modules/nf-core/shinyngs/app/main.nf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

133 changes: 133 additions & 0 deletions modules/nf-core/shinyngs/app/tests/main.nf.test

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

44 changes: 44 additions & 0 deletions modules/nf-core/shinyngs/app/tests/main.nf.test.snap

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

14 changes: 14 additions & 0 deletions modules/nf-core/shinyngs/app/tests/nextflow.config

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions modules/nf-core/shinyngs/app/tests/tags.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions modules/nf-core/shinyngs/staticdifferential/main.nf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion modules/nf-core/shinyngs/staticexploratory/environment.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading