-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dsl2 sex determination #1035
Dsl2 sex determination #1035
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- The bedfile for sexdeterrmine should be read in via the REFERENCE_INDEXING SWF (see dev docs ).
- Rename
SAMTOOLS_DEPTH
module to have a unique name (see code conventions ) -
ext.args
for sexdeterrmine samtools depth - PublishDir name needs to match output.md.
- Name of subworkflow(SWF) and its .nf file must match, AND be an imperative verb (i.e. DETERMINE_SEX), to keep in line with all other SWF (MAP, DEDUPLICATE, etc)
- remove unnecessary channel
ch_sexdeterrmine_samplelist
- No local paths in test config files.
Co-authored-by: Thiseas C. Lamnidis <[email protected]>
Co-authored-by: Thiseas C. Lamnidis <[email protected]>
Co-authored-by: Thiseas C. Lamnidis <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of minor changes. Otherwise looks good! Good job!
Co-authored-by: Thiseas C. Lamnidis <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nf-core linting re-installed the dumpsoftwareversions
module. Please remove it.
You need to delete the module files, and remove the module from modules.json
. Additionally, it seems some nf-core subworkflows were removed from the modules.json
. Try removing the entire subworkflow block rerunning linting to hopefully index them all.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dump software versions module is still there
PR checklist
nf-core lint .
).nextflow run . -profile test,docker
).docs/usage.md
is updated.docs/output.md
is updated.CHANGELOG.md
is updated.README.md
is updated (including new tool citations and authors/contributors).