Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dsl2 sex determination #1035

Merged
merged 42 commits into from
Mar 20, 2024
Merged

Dsl2 sex determination #1035

merged 42 commits into from
Mar 20, 2024

Conversation

jbv2
Copy link

@jbv2 jbv2 commented Dec 8, 2023

PR checklist

  • This comment contains a description of changes (with reason).
    • If you've added a new tool - have you followed the pipeline conventions in the [contribution docs](https://github.com/nf-core/eager/tree/master/.github/CONTRIBUTING.md)
    • If necessary, also make a PR on the nf-core/eager branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint .).
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@TCLamnidis TCLamnidis marked this pull request as draft December 8, 2023 10:56
@jbv2 jbv2 linked an issue Dec 8, 2023 that may be closed by this pull request
@jbv2 jbv2 self-assigned this Dec 8, 2023
Copy link

github-actions bot commented Dec 8, 2023

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 624ba69

+| ✅ 247 tests passed       |+
#| ❔   1 tests were ignored |#
!| ❗  22 tests had warnings |!

❗ Test warnings:

  • readme - README contains the placeholder zenodo.XXXXXXX. This should be replaced with the zenodo doi (after the first release).
  • pipeline_todos - TODO string in main.nf: Remove this line if you don't need a FASTA file
  • pipeline_todos - TODO string in nextflow.config: Specify your pipeline's command line flags
  • pipeline_todos - TODO string in README.md: Include a figure that guides the user through the major workflow steps. Many nf-core
  • pipeline_todos - TODO string in README.md: Fill in short bullet-pointed list of the default steps in the pipeline
  • pipeline_todos - TODO string in ci.yml: You can customise CI pipeline run tests as required
  • pipeline_todos - TODO string in awsfulltest.yml: You can customise AWS full pipeline tests as required
  • pipeline_todos - TODO string in main.nf: Optionally add in-text citation tools to this list.
  • pipeline_todos - TODO string in main.nf: Optionally add bibliographic entries to this list.
  • pipeline_todos - TODO string in main.nf: Only uncomment below if logic in toolCitationText/toolBibliographyText has been filled!
  • pipeline_todos - TODO string in usage.md: Add documentation about anything specific to running your pipeline. For general topics, please point to (and add to) the main nf-core website.
  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your preferred methods description, e.g. add publication citation for this pipeline
  • pipeline_todos - TODO string in test_full.config: Specify the paths to your full test data ( on nf-core/test-datasets or directly in repositories, e.g. SRA)
  • pipeline_todos - TODO string in test_full.config: Give any required params for the test so that command line flags are not needed
  • pipeline_todos - TODO string in base.config: Check the defaults for all processes
  • pipeline_todos - TODO string in base.config: Customise requirements for specific processes.
  • pipeline_todos - TODO string in test.config: Specify the paths to your test data on nf-core/test-datasets
  • pipeline_todos - TODO string in test.config: Give any required params for the test so that command line flags are not needed
  • pipeline_todos - TODO string in test_humanbam.config: Specify the paths to your test data on nf-core/test-datasets
  • pipeline_todos - TODO string in test_humanbam.config: Give any required params for the test so that command line flags are not needed
  • schema_description - No description provided in schema for parameter: skip_qualimap
  • schema_description - No description provided in schema for parameter: skip_damagecalculation

❔ Tests ignored:

  • nextflow_config - Config default ignored: params.contamination_estimation_angsd_hapmap

✅ Tests passed:

Run details

  • nf-core/tools version 2.13.1
  • Run at 2024-03-20 10:40:14

@jbv2 jbv2 requested a review from a team December 8, 2023 11:19
@jbv2 jbv2 marked this pull request as ready for review January 12, 2024 09:29
Copy link
Collaborator

@TCLamnidis TCLamnidis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • The bedfile for sexdeterrmine should be read in via the REFERENCE_INDEXING SWF (see dev docs ).
  • Rename SAMTOOLS_DEPTH module to have a unique name (see code conventions )
  • ext.args for sexdeterrmine samtools depth
  • PublishDir name needs to match output.md.
  • Name of subworkflow(SWF) and its .nf file must match, AND be an imperative verb (i.e. DETERMINE_SEX), to keep in line with all other SWF (MAP, DEDUPLICATE, etc)
  • remove unnecessary channel ch_sexdeterrmine_samplelist
  • No local paths in test config files.

CITATIONS.md Outdated Show resolved Hide resolved
conf/modules.config Outdated Show resolved Hide resolved
conf/test_humanbam.config Outdated Show resolved Hide resolved
docs/output.md Outdated Show resolved Hide resolved
docs/output.md Outdated Show resolved Hide resolved
workflows/eager.nf Outdated Show resolved Hide resolved
subworkflows/local/sex_determination.nf Outdated Show resolved Hide resolved
conf/modules.config Outdated Show resolved Hide resolved
conf/modules.config Outdated Show resolved Hide resolved
docs/output.md Outdated Show resolved Hide resolved
@jbv2 jbv2 requested a review from a team March 18, 2024 10:47
Copy link
Collaborator

@TCLamnidis TCLamnidis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of minor changes. Otherwise looks good! Good job!

conf/modules.config Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
Copy link
Collaborator

@TCLamnidis TCLamnidis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nf-core linting re-installed the dumpsoftwareversions module. Please remove it.

You need to delete the module files, and remove the module from modules.json. Additionally, it seems some nf-core subworkflows were removed from the modules.json. Try removing the entire subworkflow block rerunning linting to hopefully index them all.

@jbv2 jbv2 requested review from TCLamnidis and a team March 20, 2024 10:03
Copy link
Collaborator

@TCLamnidis TCLamnidis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dump software versions module is still there

nextflow.config Outdated Show resolved Hide resolved
@TCLamnidis TCLamnidis merged commit cb178b6 into dev Mar 20, 2024
18 checks passed
@TCLamnidis TCLamnidis deleted the dsl2-sex_determination branch March 20, 2024 11:20
@jbv2 jbv2 added this to the 3.0 Augsburg milestone Mar 20, 2024
@scarlhoff scarlhoff mentioned this pull request Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

new subworkflow: DSL2 sex determination
2 participants