-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add comBGC #188
Add comBGC #188
Conversation
Update comBGC branch to latest dev
This comment was marked as resolved.
This comment was marked as resolved.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congratulations! Release is getting close now.
subworkflows/local/bgc.nf
Outdated
COMBGC ( ch_bgcresults_for_combgc ) | ||
|
||
ch_combgc_summaries = COMBGC.out.tsv | ||
.collectFile(name: 'combgc_complete_summary.csv', storeDir: "${params.outdir}/reports/combgc", keepHeader:true) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To have it right in the output.md: will you have a summary for each sample plus the complete_summary in the output folder?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exactly. Each sample gets an output in:
reports/combgc/sampleX/combgc_summary.tsv
, and there is the concatenated version in:
reports/combgc/combgc_complete_summary.tsv
Co-authored-by: louperelo <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing documentation!
What documentation is missing? comBGC is mentioned in |
Ah fair point re docs, I'm surprised it was doucmented before it was in 😆 , see my questions on slack - will review this now again |
Closes #64
PR checklist
nf-core lint
).nextflow run . -profile test,docker --outdir <OUTDIR>
).docs/usage.md
is updated.docs/output.md
is updated.CHANGELOG.md
is updated.README.md
is updated (including new tool citations and authors/contributors).