Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "ComBGC: Add functionality to screen whole sample directory (antismash)" #261

Merged
merged 1 commit into from
Apr 21, 2023
Merged

Revert "ComBGC: Add functionality to screen whole sample directory (antismash)" #261

merged 1 commit into from
Apr 21, 2023

Conversation

jasmezz
Copy link
Collaborator

@jasmezz jasmezz commented Apr 21, 2023

Reverts #258

Forgot to pull dev before merge...

@jasmezz jasmezz requested a review from a team April 21, 2023 07:14
louperelo
louperelo approved these changes Apr 21, 2023
View reviewed changes
Copy link
Contributor

@louperelo louperelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go ahead!

@jasmezz
Copy link
Collaborator Author

jasmezz commented Apr 21, 2023

Oh wait, something is weird: In the changed files there is nothing about James ressource optimization showing up. Which was in dev before my merge. 👀

@jasmezz
Copy link
Collaborator Author

jasmezz commented Apr 21, 2023

I guess I'll just merge after checks succeed and if the ressource optimization still does not show up, create another PR.

@github-actions
Copy link

github-actions bot commented Apr 21, 2023 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit f6b2e37

+| ✅ 157 tests passed       |+
!| ❗   1 tests had warnings |!

❗ Test warnings:

  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your prefered methods description, e.g. add publication citation for this pipeline

✅ Tests passed:

Run details

  • nf-core/tools version 2.7.2
  • Run at 2023-04-21 07:27:03

@jasmezz jasmezz merged commit c955fac into dev Apr 21, 2023
@jasmezz jasmezz deleted the revert-258-combgc_new_input_param branch April 21, 2023 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louperelo louperelo louperelo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jasmezz @louperelo