Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update all modules #322

Merged
merged 5 commits into from
Nov 10, 2023
Merged

Update all modules #322

merged 5 commits into from
Nov 10, 2023

Conversation

jasmezz
Copy link
Collaborator

@jasmezz jasmezz commented Nov 10, 2023

Update all modules (introducing the environment.yml files and the changes in the list of authors/maintainers).

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/funcscan branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@jasmezz
Copy link
Collaborator Author

jasmezz commented Nov 10, 2023

@nf-core-bot fix linting

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 10, 2023 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 3f14d76

+| ✅ 159 tests passed       |+
!| ❗   1 tests had warnings |!

❗ Test warnings:

  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your preferred methods description, e.g. add publication citation for this pipeline

✅ Tests passed:

Run details

  • nf-core/tools version 2.10
  • Run at 2023-11-10 11:04:21

@jasmezz jasmezz requested a review from Darcy220606 November 10, 2023 11:06
Darcy220606
Darcy220606 approved these changes Nov 10, 2023
View reviewed changes
Copy link
Contributor

@Darcy220606 Darcy220606 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me ..

@jasmezz jasmezz merged commit bb2f4a8 into dev Nov 10, 2023
20 checks passed
@jasmezz jasmezz deleted the modules-update branch November 10, 2023 11:36
@jasmezz jasmezz mentioned this pull request Jul 29, 2024
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Darcy220606 Darcy220606 Darcy220606 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jasmezz @Darcy220606 @nf-core-bot