-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port pipeline to DSL2 #140
Conversation
Nice :) Once you updated the module, I can review this here in detail |
Please ping me on the yara module then @christopher-mohr |
I updated the In addition I would add the possibility to provide a custom |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to have this on DSL2 now. Some minor comments. I will also run once this is on dev to see if docs are matching expectations 👍🏻
Co-authored-by: Alexander Peltzer <[email protected]>
Co-authored-by: Alexander Peltzer <[email protected]>
This
hlatyping
pipeline to DSL22.6
fastq
andbam
files in the same run.We still need a better solution for handling the HLA reference. Currently it is only possible to either process
dna
orrna
data at the same time due to the HLA reference that has to be provided. My suggestion would be to choose the.fasta
automatically based on the specifiedseq_type
in the sample sheet AND allow users to specify custom.fasta
files in the sample sheet (this might need then an additional process because of thealleles.h5
file).In order to allow the use of different HLA references in the same run we also need to update the
yara_index
module and at least add themeta
map to the process I guess. @apeltzer what do you think?PR checklist
CHANGELOG.md
is updateddocs
is updated