Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update container #83

Merged
merged 2 commits into from
Jul 23, 2020
Merged

Conversation

christopher-mohr
Copy link
Collaborator

PR updating environment.yml in order to build the new container and get the test passing for PR #81. I had to change some dependencies since python3 seems to be needed now because of some other dependency (markdown?). When I did not specify the python version I got an error when running the tests.

Many thanks to contributing to nf-core/hlatyping!

Please fill in the appropriate checklist below (delete whatever is not relevant). These are the most common things requested on pull requests (PRs).

PR checklist

  • This comment contains a description of changes (with reason)
  • If you've fixed a bug or added code that should be tested, add tests!
  • If necessary, also make a PR on the nf-core/hlatyping branch on the nf-core/test-datasets repo
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Make sure your code lints (nf-core lint .).
  • Documentation in docs is updated
  • CHANGELOG.md is updated
  • README.md is updated

Learn more about contributing: https://github.com/nf-core/hlatyping/tree/master/.github/CONTRIBUTING.md

@christopher-mohr christopher-mohr merged commit 840cae6 into nf-core:dev Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants