Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version to v1.5 #152

Merged
merged 4 commits into from
Apr 9, 2020
Merged

Bump version to v1.5 #152

merged 4 commits into from
Apr 9, 2020

Conversation

ewels
Copy link
Member

@ewels ewels commented Apr 7, 2020

Bump to version 1.5. See #133 for details.

@ewels ewels requested a review from phue April 7, 2020 14:33
@ewels
Copy link
Member Author

ewels commented Apr 7, 2020

Maybe wait to resolve this merge conflict until the new docker image is built. Then we get to test the pipeline with the new software updates as a bonus.

Build is here: https://hub.docker.com/repository/registry-1.docker.io/nfcore/methylseq/builds/c31a7c6f-422b-4c82-9687-0caef2452da3

@ewels
Copy link
Member Author

ewels commented Apr 8, 2020

Build failed 😞

Package python-dateutil conflicts for:
bioconda::multiqc=1.8 -> click -> python-dateutil

I'll test locally and see if I can fix it.

@ewels
Copy link
Member Author

ewels commented Apr 8, 2020

ok, hopefully got the build working again by reverting the changes to Python, Samtools and Bowtie2. New docker image building here: https://hub.docker.com/repository/registry-1.docker.io/nfcore/methylseq/builds/3a7bbaf3-0e58-4620-b128-39415ee178ec

@ewels
Copy link
Member Author

ewels commented Apr 9, 2020

Build worked! ✅ Fixed the merge conflict - hopefully the tests will pass and we can go forward with the release...

@ewels
Copy link
Member Author

ewels commented Apr 9, 2020

Sigh. I should just not ever update anything.

    File "/opt/conda/envs/nf-core-methylseq-1.4.1/lib/python3.7/site-packages/markdown/core.py", line 387, in markdown
      md = Markdown(**kwargs)
    File "/opt/conda/envs/nf-core-methylseq-1.4.1/lib/python3.7/site-packages/markdown/core.py", line 97, in __init__
      configs=kwargs.get('extension_configs', {}))
    File "/opt/conda/envs/nf-core-methylseq-1.4.1/lib/python3.7/site-packages/markdown/core.py", line 125, in registerExtensions
      ext._extendMarkdown(self)
    File "/opt/conda/envs/nf-core-methylseq-1.4.1/lib/python3.7/site-packages/markdown/extensions/__init__.py", line 77, in _extendMarkdown
      self.extendMarkdown(md)
    File "/opt/conda/envs/nf-core-methylseq-1.4.1/lib/python3.7/site-packages/pymdownx/extra.py", line 60, in extendMarkdown
      md.registerExtensions(extra_extensions, self.config)
    File "/opt/conda/envs/nf-core-methylseq-1.4.1/lib/python3.7/site-packages/markdown/core.py", line 125, in registerExtensions
      ext._extendMarkdown(self)
    File "/opt/conda/envs/nf-core-methylseq-1.4.1/lib/python3.7/site-packages/markdown/extensions/__init__.py", line 77, in _extendMarkdown
      self.extendMarkdown(md)
    File "/opt/conda/envs/nf-core-methylseq-1.4.1/lib/python3.7/site-packages/pymdownx/extrarawhtml.py", line 30, in extendMarkdown
      extra.MarkdownInHtmlProcessor(md.parser), 'markdown_block', 105
  AttributeError: module 'markdown.extensions.extra' has no attribute 'MarkdownInHtmlProcessor'

@ewels
Copy link
Member Author

ewels commented Apr 9, 2020

Ah, same bug is reported here: nf-core/tools#571

@ewels ewels mentioned this pull request Apr 9, 2020
@ewels
Copy link
Member Author

ewels commented Apr 9, 2020

@phue
Copy link
Member

phue commented Apr 9, 2020

I can't reproduce the latest error locally :(

@ewels
Copy link
Member Author

ewels commented Apr 9, 2020

I can't reproduce the latest error locally :(

Me either - so I figured it was something weird with the GitHub actions commands. I simplified them a little and now it's working 😄

@ewels ewels merged commit d760335 into nf-core:dev Apr 9, 2020
@ewels ewels deleted the version-1.5 branch April 9, 2020 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants