Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add snippy/core module #1855

Merged
merged 11 commits into from
Sep 8, 2022
Merged

add snippy/core module #1855

merged 11 commits into from
Sep 8, 2022

Conversation

rpetit3
Copy link
Contributor

@rpetit3 rpetit3 commented Jul 6, 2022 •
edited
Loading

PR checklist

Closes #1854

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • PROFILE=docker pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
    • PROFILE=singularity pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
    • PROFILE=conda pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware

@rpetit3 rpetit3 added new module Adding a new module Ready for Review labels Jul 6, 2022
@jfy133 jfy133 self-requested a review July 6, 2022 09:32
jfy133
jfy133 approved these changes Jul 6, 2022
View reviewed changes
Copy link
Member

@jfy133 jfy133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a couple minor comments

modules/snippy/core/main.nf Show resolved Hide resolved
modules/snippy/core/main.nf Show resolved Hide resolved
modules/snippy/core/meta.yml Show resolved Hide resolved
tests/modules/snippy/core/main.nf Outdated Show resolved Hide resolved
tests/modules/snippy/core/main.nf Outdated Show resolved Hide resolved
modules/snippy/core/main.nf Outdated Show resolved Hide resolved
jfy133
jfy133 approved these changes Jul 7, 2022
View reviewed changes
modules/snippy/core/main.nf Show resolved Hide resolved
@jfy133 jfy133 merged commit 1ade577 into nf-core:master Sep 8, 2022
matthdsm pushed a commit to matthdsm/nf-core-modules that referenced this pull request Sep 28, 2022
@rpetit3 @jfy133 @matthdsm
add snippy/core module (nf-core#1855)
346dbf3 
* add snippy-core module

* Update modules/snippy/core/meta.yml

Co-authored-by: James A. Fellows Yates <[email protected]>

* Update tests/modules/snippy/core/main.nf

Co-authored-by: James A. Fellows Yates <[email protected]>

* Update tests/modules/snippy/core/main.nf

Co-authored-by: James A. Fellows Yates <[email protected]>

* Update modules/snippy/core/main.nf

Co-authored-by: James A. Fellows Yates <[email protected]>

* Update main.nf

* update test

Co-authored-by: James A. Fellows Yates <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfy133 jfy133 jfy133 approved these changes

Assignees
No one assigned
Labels
new module Adding a new module Ready for Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

new module: snippy/core
2 participants
@rpetit3 @jfy133