Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shinyngs feature/observation matrix validation module #2392

Merged

Conversation

pinin4fjords
Copy link
Member

@pinin4fjords pinin4fjords commented Oct 24, 2022

The wrapped script in shinyngs reuses a bunch of package code to ensure consistency with the various components of feature/ observation matrices (FOM, e.g. gene/ sample/ matrix) and a set of contrast definitions. I think it might be handy as an input checker for workflows such as differential abundance, but even if not it may be useful elsewhere.

PR checklist

Closes #2390

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • PROFILE=docker pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
    • PROFILE=singularity pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
    • PROFILE=conda pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware

@pinin4fjords pinin4fjords marked this pull request as draft October 24, 2022 20:14
@pinin4fjords pinin4fjords added the WIP Work in progress label Oct 24, 2022
@pinin4fjords
Copy link
Member Author

@nf-core-bot fix linting

@pinin4fjords pinin4fjords added Ready for Review and removed WIP Work in progress labels Oct 25, 2022
@pinin4fjords pinin4fjords requested a review from a team October 25, 2022 19:27
@pinin4fjords pinin4fjords marked this pull request as ready for review October 26, 2022 08:14
@pinin4fjords pinin4fjords changed the title shinyngs feature/object matrix validation module shinyngs feature/observation matrix validation module Oct 26, 2022
Copy link
Contributor

@SPPearce SPPearce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@pinin4fjords
Copy link
Member Author

Thanks for review @SPPearce

@pinin4fjords pinin4fjords merged commit 72695ee into nf-core:master Oct 31, 2022
@pinin4fjords pinin4fjords deleted the shinyngs/validatefomcomponents branch October 31, 2022 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

new module: shinyngs/validate_fom_components
3 participants