Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new module: jasminesv #2651

Merged
merged 10 commits into from
Dec 14, 2022
Merged

new module: jasminesv #2651

merged 10 commits into from
Dec 14, 2022

Conversation

nvnieuwk
Copy link
Contributor

PR checklist

Closes #2649

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • PROFILE=docker pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
    • PROFILE=singularity pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
    • PROFILE=conda pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware

@nvnieuwk nvnieuwk added new module Adding a new module Ready for Review labels Dec 13, 2022
JoseEspinosa
JoseEspinosa approved these changes Dec 13, 2022
View reviewed changes
Copy link
Member

@JoseEspinosa JoseEspinosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small question that is up to you to judge whether is worth implementing. Looks very nice! 🚀

tests/modules/nf-core/jasminesv/nextflow.config

publishDir = { "${params.outdir}/${task.process.tokenize(':')[-1].tokenize('_')[0].toLowerCase()}" }

withName: "test_jasminesv_iris:JASMINESV" {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to also test for additional iris args?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah that would be a good idea! Thanks for the suggestion, I'll look into it!

JoseEspinosa
JoseEspinosa requested changes Dec 13, 2022
View reviewed changes
Copy link
Member

@JoseEspinosa JoseEspinosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You will need to change conda syntax after #2654

modules/nf-core/jasminesv/main.nf Outdated Show resolved Hide resolved
nvnieuwk and others added 2 commits December 14, 2022 09:07
JoseEspinosa
JoseEspinosa approved these changes Dec 14, 2022
View reviewed changes
Copy link
Member

@JoseEspinosa JoseEspinosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks awesome! 🚀

@nvnieuwk nvnieuwk merged commit 6e09b05 into nf-core:master Dec 14, 2022
@nvnieuwk nvnieuwk deleted the jasminesv branch December 14, 2022 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoseEspinosa JoseEspinosa JoseEspinosa approved these changes

Assignees
No one assigned
Labels
new module Adding a new module Ready for Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

new module: jasminesv
2 participants
@nvnieuwk @JoseEspinosa