Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update macrel version to 1.2.0 #3001

Merged
merged 17 commits into from
Apr 5, 2023
Merged

Conversation

Darcy220606
Copy link
Contributor

@Darcy220606 Darcy220606 commented Mar 8, 2023

PR checklist

This PR is to opdate the MACREL/CONTGS version from 1.1.0 to 1.2.0. No parameters are changed, just the containers and md5Sums in test.yml.

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • PROFILE=docker pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
    • PROFILE=singularity pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
    • PROFILE=conda pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware

@Darcy220606 Darcy220606 requested a review from jfy133 March 29, 2023 10:20
Copy link
Member

@jfy133 jfy133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jfy133 jfy133 enabled auto-merge March 29, 2023 12:29
@jfy133 jfy133 disabled auto-merge March 29, 2023 12:29
Remove the md5 sums for the `smorfs` file because it changes with conda and docker/singularity.
@Darcy220606 Darcy220606 added this pull request to the merge queue Apr 5, 2023
Merged via the queue into nf-core:master with commit a5a5bb1 Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

2 participants