Fix subworkflows based on json schema #3306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirpedrol
reviewed
Apr 19, 2023
This was referenced Apr 26, 2023
|
cf #3340 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yet another json schema, this time for subworkflows (needed so they are all nicely rendered on the website).
In order for the two schemas to behave nicely, I had to split them into two files and put them into the respective subfolders. It is very similar to the schema for modules, biggest difference is that I don't require types for the input and output, because it felt like 90% was some kind of
map(you can still give them and they will be rendered on the homepage).I fixed the broken meta.yaml according to this new rules.
I also added the hint for the yaml-language server, to nicely show the problems already in the editor (thanks @emiller88 for pointing this out)