fix-meta-liniting

[sateeshperi]

PR checklist

Closes #XXX

• This comment contains a description of changes (with reason).
• If you've fixed a bug or added code that should be tested, add tests!
• If you've added a new tool - have you followed the module conventions in the contribution docs
• If necessary, include test data in your PR.
• Remove all TODO statements.
• Emit the versions.yml file.
• Follow the naming conventions.
• Follow the parameters requirements.
• Follow the input/output options guidelines.
• Add a resource label
• Use BioConda and BioContainers if possible to fulfil software requirements.
• Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
  • PROFILE=docker pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
  • PROFILE=singularity pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
  • PROFILE=conda pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware

[JoseEspinosa]

Nice, I think that two of the types should be maintained as boolean but maybe there is a reason to change it that is unknow to me

[JoseEspinosa]

Is this not a boolean?

[mashehu]

we don't have boolean as a type, see (https://nf-co.re/docs/contributing/modules#documentation point 8). Not sure if that is a nextflow limitation (I would be for it)

[JoseEspinosa]

I see that the PR is now closed, but I wanted to clarify this point anyway. I checked the modules repo and when I searched for type: boolean there are 72 occurrences in meta.ymls files both in modules and subworkflows. So if this is not allowed we should get rid of them. When you say this is a nextflow limitation what do you mean exactly? Thanks!

[sateeshperi]

ya i see those 72 too....i think we will have to change those too but,I am also curious as to why boolean is not supported @mashehu . now that we specify as string, will providing "true" be the same as true ?

[mashehu]

was just going off of the guidelines, which I think @jfy133 worked on.

[mashehu]

But since we don't validate these types anywhere (besides in json-schema for meta.yml) and don't use them anywhere AFAIK (besides rendering them on the website), I am all for adding boolean as a type to the guidelines.

[jfy133]

We should have a boolean! This documenation was added was before allowing non-file inputs :)
(docs also describe outputs which is why we have other types, but I've never heard of an boolean ouput)

Please add, as a new category rather than astring!

[mashehu]

We had it already in the schema, added it also to the guidelines now: https://github.com/nf-core/nf-co.re/pull/1767/files

[sateeshperi]

will tools also need an update? as linting with boolean fails

[JoseEspinosa]

Same here

[ewels]

Merged into PR #3344 and then merged into master in b9829e1.

Thanks @sateeshperi !