Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add bedops/gtf2bed #4476

Merged
merged 22 commits into from
May 13, 2024
Merged

add bedops/gtf2bed #4476

merged 22 commits into from
May 13, 2024

Conversation

davidecarlson
Copy link
Contributor

@davidecarlson davidecarlson commented Nov 28, 2023

PR checklist

Adding a module for bedops/gtf2bed with the eventual goal to try to replace the local gtf2bed module in the rnaseq pipeline. Even if that is not feasible, the module may still potentially be useful elsewhere.

This is my first new module PR, so please let me know if I've missed anything.

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • PROFILE=docker pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
    • PROFILE=singularity pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
    • PROFILE=conda pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware

Thanks!
Dave

@davidecarlson davidecarlson requested a review from a team as a code owner November 28, 2023 21:25
@davidecarlson davidecarlson requested review from maxulysse and removed request for a team November 28, 2023 21:25
@SPPearce SPPearce enabled auto-merge May 13, 2024 15:37
@SPPearce SPPearce added this pull request to the merge queue May 13, 2024
Merged via the queue into nf-core:master with commit bdca0f1 May 13, 2024
12 checks passed
@davidecarlson davidecarlson deleted the gtf2bed branch May 14, 2024 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants