-
Notifications
You must be signed in to change notification settings - Fork 749
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added classic mlst module #742
Conversation
I'm not sure if this is helpful/informative or not
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great @lskatz ! Mainly minor changes as a result of recent updates we are trying to push to nf-core/modules. Sorry, a little bit of bad timing here.
The CI tests will be stalled because have maxed them out updating all of the other modules #739. In any case, I think it would be a good idea to get that PR in first and then we can come back to get this in after you have made the appropriate changes :)
Thank you! I made changes locally so that I could get the muscle memory and pushed those changes to this PR. |
Thanks guys! |
PR checklist
Closes #XXX
versions.yml
file. I think I did this right?label
PROFILE=docker pytest --tag <MODULE> --symlink --keep-workflow-wd
PROFILE=singularity pytest --tag <MODULE> --symlink --keep-workflow-wd
PROFILE=conda pytest --tag <MODULE> --symlink --keep-workflow-wd