-
Notifications
You must be signed in to change notification settings - Fork 716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev -> Master for 3.13.0 release #1113
Conversation
…ination with the STAR-RSEM route.
Co-authored-by: Harshil Patel <[email protected]>
Display a warning when '--star_extra_alignment_args' are used with RSEM
Update public_aws_ecr.config
Remove public_aws_ecr profile
Important! Template update for nf-core/tools v2.9
Update credits for subway map
Use nf-validation plugin for parameter and samplesheet validation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
conf/test.config
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, so what happened with the rnaseq
-> 7f1614baeb0ddf66e60be78c3d9fa55440465ac8
bit?
We should not change files that already there if it break tests, but add new ones and change the link in this PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because stuff like this happens (you literally approved a test file change I PR'd the other day :-D ), and using a commit makes sure it won't break anything if it does :-). I don't think we should be relying on the good sense of human beings for this sort of thing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, I know, but that was in dev, now it's for a release, the stakes are higher
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor requests
Maxime feedback
FIX: Subway map
final updates on subway map
No description provided.