Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Azure Batch guidance #1340

Merged
merged 4 commits into from
Jul 15, 2024
Merged

Update Azure Batch guidance #1340

merged 4 commits into from
Jul 15, 2024

Conversation

adamrtalbot
Copy link
Contributor

Updated Azure Batch guidance to use a machine that would actually work 🤦 .

Do we even need this? Can we just remove this section?

@adamrtalbot
Update Azure Batch guidance
eb4e362 
Updated Azure Batch guidance to use a machine that would actually work 🤦 .

Do we even need this? Can we just remove this section?
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 9, 2024 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 17444ff

+| ✅ 173 tests passed       |+
#| ❔   9 tests were ignored |#
!| ❗   7 tests had warnings |!

❗ Test warnings:

  • files_exist - File not found: assets/multiqc_config.yml
  • files_exist - File not found: .github/workflows/awstest.yml
  • files_exist - File not found: .github/workflows/awsfulltest.yml
  • pipeline_todos - TODO string in main.nf: Optionally add in-text citation tools to this list.
  • pipeline_todos - TODO string in main.nf: Optionally add bibliographic entries to this list.
  • pipeline_todos - TODO string in main.nf: Only uncomment below if logic in toolCitationText/toolBibliographyText has been filled!
  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your preferred methods description, e.g. add publication citation for this pipeline

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.14.1
  • Run at 2024-07-12 17:48:06

pinin4fjords
pinin4fjords approved these changes Jul 11, 2024
View reviewed changes
Copy link
Member

@pinin4fjords pinin4fjords left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but also not sure why exactly we need this. Have asked @drpatelh

@pinin4fjords pinin4fjords added this to the 3.15.0 milestone Jul 11, 2024
@adamrtalbot
Copy link
Contributor Author

@pinin4fjords shall we make the executive decision to remove it? Azure Batch has better options anyway: https://github.com/nf-core/configs/blob/master/conf/pipeline/rnaseq/azurebatch_pools_Edv4.config

@pinin4fjords
Copy link
Member

Sounds good. Even if the documentation is useful I feel like it should live in somewhere more generic (Nextflow/ nf-core)

@drpatelh
Copy link
Member

Agree to ditch too! Infra docs and configuration like this should live somewhere outside of the pipeline repo. Apologies for the delay!

@pinin4fjords
Copy link
Member

pinin4fjords commented Jul 12, 2024 •
edited
Loading

There's no changelog edit- if we care for something this small....

@adamrtalbot
Copy link
Contributor Author

done: 17444ff

@pinin4fjords pinin4fjords merged commit ccd95ab into dev Jul 15, 2024
25 checks passed
@pinin4fjords pinin4fjords deleted the update-azure-batch-guidance branch July 15, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pinin4fjords pinin4fjords pinin4fjords approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.15.0
Development

Successfully merging this pull request may close these issues.
3 participants
@adamrtalbot @pinin4fjords @drpatelh