Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-arrange and annotate modules.config #740

Merged
merged 4 commits into from
Dec 16, 2021
Merged

Re-arrange and annotate modules.config #740

merged 4 commits into from
Dec 16, 2021

Conversation

drpatelh
Copy link
Member

Bumped picard version #734

@github-actions
Copy link

github-actions bot commented Dec 16, 2021 •
edited
Loading

nf-core lint overall result: Passed ✅

Posted for pipeline commit eeac03b

+| ✅ 137 tests passed       |+
#| ❔   3 tests were ignored |#

❔ Tests ignored:

  • files_unchanged - File ignored due to lint config: assets/email_template.html
  • files_unchanged - File ignored due to lint config: assets/email_template.txt
  • files_unchanged - File ignored due to lint config: lib/NfcoreTemplate.groovy

✅ Tests passed:

Run details

  • nf-core/tools version 2.2
  • Run at 2021-12-16 13:25:25

@drpatelh drpatelh mentioned this pull request Dec 16, 2021
Closed
@drpatelh
Copy link
Member Author

Re-organised modules.config and added some comments to be compatible with my blocky 🧠 😬 May need to look at the file itself rather than the changes.

Also removed this duplicated block here

mahesh-panchal
mahesh-panchal approved these changes Dec 16, 2021
View reviewed changes
Copy link
Member

@mahesh-panchal mahesh-panchal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it looks good. All process's accounted for I think.
Using the VScode side-by-side view in the browser worked ok. ( press . on a pull request )

@drpatelh drpatelh merged commit 28ef622 into nf-core:dev Dec 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mahesh-panchal mahesh-panchal mahesh-panchal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@drpatelh @mahesh-panchal