Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev -> Master for v3.8 release #832

Merged
merged 14 commits into from
May 25, 2022
Merged

Dev -> Master for v3.8 release #832

merged 14 commits into from
May 25, 2022

Conversation

drpatelh
Copy link
Member

No description provided.

@github-actions
Copy link

This PR is against the master branch ❌

  • Do not close this PR
  • Click Edit and change the base to dev
  • This CI test will remain failed until you push a new commit

Hi @drpatelh,

It looks like this pull-request is has been made against the nf-core/rnaseq master branch.
The master branch on nf-core repositories should always contain code from the latest release.
Because of this, PRs to master are only allowed if they come from the nf-core/rnaseq dev branch.

You do not need to close this PR, you can change the target branch to dev by clicking the "Edit" button at the top of this page.
Note that even after this, the test will continue to show as failing until you push a new commit.

Thanks again for your contribution!

@github-actions
Copy link

github-actions bot commented May 24, 2022 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 8f59050

+| ✅ 144 tests passed       |+
#| ❔   3 tests were ignored |#
!| ❗   2 tests had warnings |!

❗ Test warnings:

  • nextflow_config - Config manifest.version should end in dev: '3.8'
  • readme - README did not have a Nextflow minimum version badge.

❔ Tests ignored:

  • files_unchanged - File ignored due to lint config: assets/email_template.html
  • files_unchanged - File ignored due to lint config: assets/email_template.txt
  • files_unchanged - File ignored due to lint config: lib/NfcoreTemplate.groovy

✅ Tests passed:

Run details

  • nf-core/tools version 2.4.1
  • Run at 2022-05-25 08:25:26

@drpatelh drpatelh closed this May 24, 2022
@drpatelh drpatelh reopened this May 24, 2022
JoseEspinosa
JoseEspinosa approved these changes May 24, 2022
View reviewed changes
Copy link
Member

@JoseEspinosa JoseEspinosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀
Feel free to merge once the problem with the PR error is solved, I saw your comment on the tools slack channel

@drpatelh
Copy link
Member Author

Ok. Going to merge this because we know the failing tests shouldn't be failing and it shouldn't affect anything else. We can test and fix this in the pipeline template. Created an issue nf-core/tools#1609

@drpatelh drpatelh merged commit 6995330 into master May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mahesh-panchal mahesh-panchal mahesh-panchal approved these changes

@JoseEspinosa JoseEspinosa JoseEspinosa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@drpatelh @JoseEspinosa @mahesh-panchal @nf-core-bot